Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

components/Agents/PrivacySection.tsx (1)

26-33: Minor: Inconsistent JSX indentation.

The EmailShareInput component and its props have extra leading spaces compared to the surrounding JSX. While functionally correct, aligning the indentation would improve readability.

✨ Aligned indentation

      {isPrivate && (
        <EmailShareInput
-            emails={form.watch("shareEmails") ?? []}
-            existingSharedEmails={existingSharedEmails}
-            onEmailsChange={(emails) => {
-              form.setValue("shareEmails", emails, { shouldDirty: true, shouldValidate: true });
-            }}
-            onExistingEmailsChange={onExistingEmailsChange}
-          />
+          emails={form.watch("shareEmails") ?? []}
+          existingSharedEmails={existingSharedEmails}
+          onEmailsChange={(emails) => {
+            form.setValue("shareEmails", emails, { shouldDirty: true, shouldValidate: true });
+          }}
+          onExistingEmailsChange={onExistingEmailsChange}
+        />
      )}

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@components/Agents/PrivacySection.tsx` around lines 26 - 33, The JSX for
EmailShareInput is misaligned with extra leading spaces; open the component
block containing EmailShareInput and normalize indentation so the tag and all
its props (EmailShareInput, emails prop using form.watch("shareEmails"),
existingSharedEmails, onEmailsChange handler that calls form.setValue(...), and
onExistingEmailsChange) align with the surrounding JSX structure—ensure each
prop is indented consistently (same level as neighboring components) for
readable, consistent formatting.

hooks/useAgentForm.ts (1)

24-30: Simplify the useEffect - the else-if branch is unreachable.

Given that defaultValues.shareEmails is always initialized to initialValues?.shareEmails ?? [] on line 18, form.getValues("shareEmails") will never be falsy. The condition on line 27 is effectively dead code.

♻️ Simplified effect

  useEffect(() => {
    if (!isPrivate) {
      form.setValue("shareEmails", []);
-   } else if (!form.getValues("shareEmails")) {
-     form.setValue("shareEmails", []);
    }
  }, [isPrivate, form]);

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@hooks/useAgentForm.ts` around lines 24 - 30, The else-if branch in the
useEffect is unreachable because defaultValues.shareEmails is always initialized
(via initialValues?.shareEmails ?? []), so simplify the effect: keep the check
on isPrivate and call form.setValue("shareEmails", []) when !isPrivate, and
remove the redundant else-if that checks form.getValues("shareEmails"); update
the useEffect that references isPrivate, form.setValue, and form.getValues
accordingly.

hooks/useEditAgentTemplate.ts (2)

22-24: Consider deduplicating emails before sending to API.

The merge of currentSharedEmails and values.shareEmails could theoretically produce duplicates if the same email appears in both arrays. While the current UI flow makes this unlikely (per context, form always resets shareEmails to []), adding deduplication would be a defensive measure against future edge cases.

♻️ Optional deduplication

      const finalShareEmails = values.isPrivate
-       ? [...currentSharedEmails, ...(values.shareEmails ?? [])]
+       ? [...new Set([...currentSharedEmails, ...(values.shareEmails ?? [])])]
        : [];

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@hooks/useEditAgentTemplate.ts` around lines 22 - 24, The merged email array
assigned to finalShareEmails in useEditAgentTemplate.ts can contain duplicates
from currentSharedEmails and values.shareEmails; update the assignment so when
values.isPrivate is true you deduplicate the combined list (e.g., use a Set or
filter to preserve first-occurrence order) before sending to the API, while
keeping the existing isPrivate branch behavior (and ensure the deduplication
happens only when computing finalShareEmails).

---

29-31: Consider guarding against undefined userId before making the request.

If userData hasn't loaded yet, userId will be undefined, and the API will reject with a 400 error (per the PATCH handler at app/api/agent-templates/route.ts:154-156). While the mutation will throw and error handling will catch it, the user experience would be clearer with an early guard or by disabling the submit action until user data is available.

🛡️ Proposed early validation

  return useMutation({
    mutationFn: async (values: CreateAgentFormData) => {
+     if (!userData?.id) {
+       throw new Error("User not authenticated");
+     }
+
      const finalShareEmails = values.isPrivate
        ? [...currentSharedEmails, ...(values.shareEmails ?? [])]
        : [];

      const res = await fetch("/api/agent-templates", {
        method: "PATCH",
        headers: { "Content-Type": "application/json" },
        body: JSON.stringify({
          id: agent.id,
-         userId: userData?.id,
+         userId: userData.id,

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@hooks/useEditAgentTemplate.ts` around lines 29 - 31, The request body may
include an undefined userId when userData hasn't loaded; update the mutation in
useEditAgentTemplate (the code that builds body: JSON.stringify({ id: agent.id,
userId: userData?.id, ... })) to guard early: if userData?.id is falsy, abort
the request and surface a clear error (or return early) so no PATCH is sent with
undefined userId; alternatively ensure the submit action is disabled until
userData is present—change the check in the mutation handler that constructs the
body to validate userData?.id and handle the missing user id before calling
fetch.

components/Agents/AgentsVisibilityFilter.tsx (1)

3-11: Refactor to a value-change API to support controlled + uncontrolled usage.

The current togglePrivate contract couples this component to flip semantics and forces click guards in the view layer. Prefer a standard value/defaultValue + onValueChange(next) shape so the component can be reused cleanly in both controlled and uncontrolled modes.

♻️ Proposed refactor

+import { useState } from "react";
 import { cn } from "@/lib/utils";

 interface AgentsVisibilityFilterProps {
-  isPrivate: boolean;
-  togglePrivate: () => void;
+  isPrivate?: boolean;
+  defaultIsPrivate?: boolean;
+  onIsPrivateChange?: (next: boolean) => void;
 }

 const AgentsVisibilityFilter = ({
-  isPrivate,
-  togglePrivate,
+  isPrivate: controlledIsPrivate,
+  defaultIsPrivate = false,
+  onIsPrivateChange,
 }: AgentsVisibilityFilterProps) => {
+  const [uncontrolledIsPrivate, setUncontrolledIsPrivate] = useState(defaultIsPrivate);
+  const isPrivate = controlledIsPrivate ?? uncontrolledIsPrivate;
+  const setIsPrivate = (next: boolean) => {
+    if (controlledIsPrivate === undefined) setUncontrolledIsPrivate(next);
+    onIsPrivateChange?.(next);
+  };
+
   return (
     <div
       role="group"
       aria-label="Agent visibility filter"
       className="inline-flex h-9 items-center justify-center rounded-lg bg-muted p-1 text-muted-foreground"
     >
       <button
         type="button"
         aria-pressed={!isPrivate}
-        onClick={() => {
-          if (isPrivate) togglePrivate();
-        }}
+        onClick={() => setIsPrivate(false)}
         className={cn(
           "inline-flex items-center justify-center whitespace-nowrap rounded-md px-3 py-1 text-sm font-medium transition-all cursor-pointer",
           !isPrivate
             ? "bg-background text-foreground shadow"
             : "text-muted-foreground hover:text-foreground"
         )}
       >
         Public
       </button>
       <button
         type="button"
         aria-pressed={isPrivate}
-        onClick={() => {
-          if (!isPrivate) togglePrivate();
-        }}
+        onClick={() => setIsPrivate(true)}
         className={cn(
           "inline-flex items-center justify-center whitespace-nowrap rounded-md px-3 py-1 text-sm font-medium transition-all cursor-pointer",
           isPrivate
             ? "bg-background text-foreground shadow"
             : "text-muted-foreground hover:text-foreground"
         )}
       >
         Private
       </button>
     </div>
   );
 };

As per coding guidelines: "Support both controlled and uncontrolled state in components" and "Provide defaultValue and onValueChange props for state management."

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@components/Agents/AgentsVisibilityFilter.tsx` around lines 3 - 11, Change the
component API from isPrivate + togglePrivate to a value/defaultValue +
onValueChange(next: boolean) shape: update the AgentsVisibilityFilterProps to
accept value?: boolean, defaultValue?: boolean, and onValueChange?: (next:
boolean) => void, then inside AgentsVisibilityFilter use the controlled pattern
(use the passed value when defined otherwise keep internal state initialized
from defaultValue) and call onValueChange(next) whenever the visibility changes;
replace any togglePrivate usages/click handlers to compute the next boolean and
call onValueChange(next) (or update internal state when uncontrolled).
Reference: AgentsVisibilityFilter and AgentsVisibilityFilterProps (rename
togglePrivate → onValueChange, isPrivate → value/defaultValue) and ensure event
handlers use the new onValueChange(next) contract.